This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Try to use AuthenticationServiceInterface for the Identity helper #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
previously requested changes
Jul 13, 2018
|
@froschdesign, updated. |
|
Please use the Thank you in advance! |
gszy
changed the title
gszy
changed the title
It supports both `AuthenticationService` and `AuthenticationServiceInterface`.
Extracts the method `discoverAuthenticationService()` from `IdentityFactory::__invoke()`, allowing removal of an if/else, and simplifying the logic of the main factory method.
weierophinney
dismissed
froschdesign’s stale review
Author provided changes as requested.
|
Thanks, @gscscnd! |
gszy
deleted the
use-authenticationserviceinterface-in-identity-view-helper
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zendframework/zend-mvc-plugin-identity#9
Closes #33