Zend\Stdlib\PriorityList cannot contain false values

[Grundik]

As a consequence, Zend\Db\Sql\Update not only cannot set false values, but also stop setting any values beyond false one.

$platform = new \Zend\Db\Adapter\Platform\Mysql(new \Zend\Db\Adapter\Driver\Mysqli\Mysqli(null));
// just for convenience, platform really doesn't matter, because bug in PriorityList

$sql = new \Zend\Db\Sql\Update('table');
$sql->set(array('value2'=>'test', 'value3'=>true, 'value1'=>false));
echo $sql->getSqlString($platform);
// UPDATE `table` SET `value2` = 'test', `value3` = '1'
// value1 silently discarded

$sql2 = new \Zend\Db\Sql\Update('table');
$sql2->set(array('value1'=>false, 'value2'=>'test', 'value3'=>true));
echo $sql2->getSqlString($platform);
// UPDATE `table` SET
// Totally malformed request, all values discarded

PriorityList->valid() checks, is ->current() returns false. But ->current() returns false not only if current item is invalid, but also when item is false.

[samsonasik]

afaik, boolean in db use tinyint(1) for 0 as false or 1 as true. why not use 0 and 1 instead ? maybe you can do :

$sql->set(array('value2'=>'test', 'value3'=>(int) true, 'value1'=> (int) false));

with cast with (int) ...

[samsonasik]

btw, I have tried to create PR #6773 to it

[Grundik]

Yes, using integers is a workaround. But is not it better to have a library to work correctly?

This bug reminds me similar ZF1 bug: http://framework.zend.com/issues/browse/ZF-1457 Still actual, 7 years old, btw. Seems like booleans in database is a pain point of ZF.

[samsonasik]

Yeah, could you take a look at PR #6773 and maybe suggest some feedback if there is something missing ?

[Grundik]

Maybe its better not interfere by converting types, since PriorityList in Stdlib package. Something like this: Grundik@e9812a0

[samsonasik]

@Grundik yes, that's better. I've pulled your branch to my branch, combined at #6773 .
Thanks.