This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix several cs #2306
Merged
Fix several cs #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix "use" and multiple spaces
add fix cs with space after comma
add space with string concatenation
| // found param | ||
| $param = $params[$x]; | ||
|
|
||
| // prevent further scanning of this param | ||
| array_splice($params,$x,1); | ||
| array_splice($params, $x,1); |
|
Maks3w, add new commit to add CS with your comment. |
add cs with space arount
|
New fixs and fix with your comment. |
fix whitespace CS
| @@ -61,7 +61,7 @@ public function __construct(XMLRPCClient $client, $namespace = '') | |||
| */ | |||
| public function __get($namespace) | |||
| { | |||
| $namespace = ltrim("$this->namespace.$namespace", '.'); | |||
| $namespace = ltrim("$this->namespace . $namespace", '.'); | |||
There was a problem hiding this comment.
This is not doing what you think it's doing, and causes a test failure.
weierophinney
added a commit
that referenced
this pull request
Sep 13, 2012
- CS does not apply within strings
|
Fixed the XmlRpc testing issue, and merged to release and master. |
ghost
assigned
|
oh, don't see, sorry! |
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
- CS does not apply within strings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several coding standard to keep new 2.0.0 more clean :)