This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
ZF2-482 Attempt to fix the buffer. Also added extra unit tests. #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have to find a good way to test the ResultInterface
ghost
assigned 
|
This PR is for two separate issues, can you make two separate pull requests, one for each issue? |
|
It actually look like #2325 might contain one of these commits? |
|
@kpieters Can you remove the rouge commit from this PR? Otherwise can I close it? |
|
I've send a new pull request to develop #2380 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still have to find a good way to test the ResultInterface