This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Render name of alias that already exists in exception message #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new Exception\InvalidServiceNameException('An alias by this name already exists'); | ||
| throw new Exception\InvalidServiceNameException(sprintf( | ||
| 'An alias by the name "%s" already exists', | ||
| $alias |
There was a problem hiding this comment.
Shall I fix something here?
… the exception message
|
@Maks3w I've updated the exception message. Should it be more verbose? |
|
Thank you @localheinz this is enough, if not you can spend a long time looking for a ghost bug when the exception message hides the other reason |
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…d-detail-to-exception-message'
gianarb
pushed a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it quite useful to see the name of the alias that already exists, therefore I added it to the exception message.