This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add __destruct to SessionManager #3429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose, writeClose now checks to see if the storage is immutable prior to attempting to save since the destructor may call writeClose a second time
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a __destruct method into the SessionManager to ensure that writeClose is called prior to PHP destroying the object references from a session becoming closed. When the destructor is called it will then call writeClose; in the event that writeClose was already called the storage would then be marked as Immutable. Therefore writeClose now additionally checks to ensure that if the storage is immutable it will not execute the closing again.
This issue happens primarily when utilizing a database storage handler or something that rewrite other resources.
Issues Resolved
#2628
#3075
#3108
#3182