Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Added @method annotations for view helpers #3924

Merged
merged 1 commit into from Mar 7, 2013
Merged

Added @method annotations for view helpers #3924

merged 1 commit into from Mar 7, 2013

Conversation

bramstroker
Copy link
Contributor

I have added @method annotations for all the builtin view helpers, so we can have IDE completion for the view helpers.
This is based on my discussion with Ocramius at StackOverflow. The same thing is already implemented in the AbstractController for controller plugins.

I was not sure if I also need to add the translation view helpers which are located in the zend_i18n package. The zend_view component doesn't have a dependency on zend_i18n so that's why I left them out.

Freeaqingme added a commit that referenced this pull request Mar 7, 2013
@Freeaqingme Freeaqingme merged commit 907e031 into zendframework:master Mar 7, 2013
Freeaqingme added a commit that referenced this pull request Mar 7, 2013
@Freeaqingme
Copy link
Member

Thanks for the PR, I like it! ;)

@weierophinney Can you say something wise about the zend_i18n methods? Personally, I'd opt to add those as well, even though they are not a dependency.

@bramstroker
Copy link
Contributor Author

@Freeaqingme Thanks for merging. Same goes for the zend_form methods.

@weierophinney What to do with the zend_form methods? I prefer to have those in the ViewRenderer as well.

@micheh
Copy link
Contributor

micheh commented Mar 7, 2013

This is very inconsistent. Sometimes you use self::... (which probably cannot be resolved), aliases (e.g. HeadScript::FILE, which some IDEs can't resolve), FQCN (\Zend\View\Helper\Placeholder\Container\AbstractContainer::APPEND) and strings ('APPEND').

@bramstroker
Copy link
Contributor Author

@micheh: thanks for pointing. it should be all FQCN's. I'll correct things asap.

@bramstroker
Copy link
Contributor Author

@micheh: Created a new PR to fix this issue. String 'APPEND' is equal to the method declaration, there is no constant for this eighter I think.

gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants