Hotfix/case sensitive console #4005

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

blanchonvincent commented Mar 11, 2013

After write the tests on Console, i see a bug on the sensitive case.
It was possible to configure sensitive case (or not sensitive), but the reading was only always insensitive.

This bug is fix and i had tests on the Prompt\Confirm.

I make a consistency between console reading char too and delete a useless loop on the reading char which are already done in the console adapter.

@ThomasCantonnet ThomasCantonnet and 1 other commented on an outdated diff Mar 12, 2013

tests/ZendTest/Console/Prompt/ConfirmTest.php
+ public function setUp()
+ {
+ $this->adapter = new ConsoleAdapter();
+ $this->adapter->stream = fopen('php://memory', 'w+');
+ }
+
+ public function tearDown()
+ {
+ fclose($this->adapter->stream);
+ }
+
+ public function testCanPromptConfirm()
+ {
+ fwrite($this->adapter->stream, 'y');
+
+ $confirm = new Confirm("ZF2 is the better framework ?");
@ThomasCantonnet

ThomasCantonnet Mar 12, 2013

Contributor

"Is ZF2 the best framework?" ;)

@blanchonvincent

blanchonvincent Mar 12, 2013

Contributor

thank you :)

@weierophinney weierophinney added a commit that referenced this pull request Mar 12, 2013

@weierophinney weierophinney Merge pull request #4005 from blanchonvincent/hotfix/case-sensitive-c…
…onsole

Hotfix/case sensitive console
8879313

@weierophinney weierophinney added a commit that referenced this pull request Mar 12, 2013

@weierophinney weierophinney [#4005] CS fixes
- trailing whitespace
7a5690a

@weierophinney weierophinney added a commit that referenced this pull request Mar 12, 2013

@weierophinney weierophinney Merge branch 'hotfix/4005' into develop
Forward port #4005
b7139a6

@curious-eyes curious-eyes added a commit to curious-eyes/zf2 that referenced this pull request Mar 18, 2013

@weierophinney @curious-eyes weierophinney + curious-eyes [#4005] CS fixes
- trailing whitespace
84e2c4d

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#4005 from blanchonvinc…
…ent/hotfix/case-sensitive-console

Hotfix/case sensitive console
98485c4

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#4005] CS fixes
- trailing whitespace
f05077e

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/4005' d753e94

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/4005' into develop ca3399f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment