Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

POP3 protocol "return;" is needed after APOP request #4312

Merged
merged 1 commit into from Apr 25, 2013
Merged

POP3 protocol "return;" is needed after APOP request #4312

merged 1 commit into from Apr 25, 2013

Conversation

colun
Copy link
Contributor

@colun colun commented Apr 25, 2013

"return;" existed before Apr 30, 2012(not inclusive). However, "return;" was erased in Apr 30, 2012. I think it is human error. "return;" is needed in POP3 protocol.

…n;" was erased in Apr 30, 2012. I think it is human error. "return;" is needed in POP3 protocol.
@bayleedev
Copy link
Contributor

Can you create a test with a use case?

@colun
Copy link
Contributor Author

colun commented Apr 25, 2013

Error testcase's packet is following. (using Wire Shark)

recv: +OK ****** pop server at *_.com starting. <11111.1111111111@_.com>
send: APOP hoge 0123456789abcdef0123456789abcdef
recv: +OK hoge has *
messages in ****** octets.
send: USER hoge
recv: -ERR Unknown command: "user".
send: QUIT
recv: +OK Pop server at *********** signing off.

@colun
Copy link
Contributor Author

colun commented Apr 25, 2013

The authentification of USER and PASS is unnecessary if the authentification of APOP succeeds.
Therefore the authentification of USER and PASS is often prohibited.

@sasezaki
Copy link
Contributor

Hi @colun. Thanks for your report.

I agree your "human error " suggestion. because it is introduced by this commit.
535de4b#L16L251
(oh, this commit message mentioned some fixing CS & typo )

ping @Maks3w

weierophinney added a commit that referenced this pull request Apr 25, 2013
POP3 protocol "return;" is needed after APOP request
weierophinney added a commit that referenced this pull request Apr 25, 2013
@ghost ghost assigned weierophinney Apr 25, 2013
@weierophinney weierophinney merged commit e303d53 into zendframework:develop Apr 25, 2013
@colun colun deleted the develop branch April 26, 2013 03:49
weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
POP3 protocol "return;" is needed after APOP request
weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants