Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

ProxyManager bugfix #5198

Closed
wants to merge 2 commits into from
Closed

ProxyManager bugfix #5198

wants to merge 2 commits into from

Conversation

blanchonvincent
Copy link
Contributor

No description provided.

@blanchonvincent
Copy link
Contributor Author

@Ocramius have a look please

@Ocramius
Copy link
Member

Ocramius commented Oct 1, 2013

@blanchonvincent this still dumps all the files to disk (see the EvaluatingGeneratorStrategy bit) - any way of allowing that too? :)

@blanchonvincent
Copy link
Contributor Author

@Ocramius Hmm I think I don't understand. If you use "write_proxy_files => false", you'll use the EvaluatingGeneratorStrategy ?

@Ocramius
Copy link
Member

Ocramius commented Oct 1, 2013

Yes basically :-)

@blanchonvincent
Copy link
Contributor Author

@Ocramius and I made a mistake ? Sorry Marco, I think I don't where I wrong in this PR :/

@weierophinney
Copy link
Member

@blanchonvincent Can you add a description to the PR indicating the problem you encountered, and how you're attempting to solve it, please? When I look at the changes, I have doubts about what you're trying to accomplish, and whether the approach is sound... but mostly due to the fact that I'm unclear what the purpose is.

@Ocramius
Copy link
Member

@blanchonvincent may I also suggest a dev dependency bump? :)

@blanchonvincent
Copy link
Contributor Author

@weierophinney I added a fail test case : https://github.com/blanchonvincent/zf2/blob/d08395942f275d32cf2af308d1b9b2044ca4c2c3/tests/ZendTest/ServiceManager/Proxy/LazyServiceFactoryFactoryTest.php#L82

This has been fixed in ProxyManager project : https://github.com/Ocramius/ProxyManager/pull/87/files

The problem is when auto_generate_proxies is equal to true, because if the proxy was never generated, it will be never generate.

@blanchonvincent
Copy link
Contributor Author

@Ocramius what is a dev dependency bump ? a dependence from the ProxyManager project ?

@Ocramius
Copy link
Member

Yep, basically using 0.5.x for running the tests

@blanchonvincent
Copy link
Contributor Author

@Ocramius Yep, agree if we can

@weierophinney
Copy link
Member

@blanchonvincent and @Ocramius -- any news on completing this? or should I close?

@blanchonvincent
Copy link
Contributor Author

This PR fix a bug (see the fail test case), so maybe can we merge ? cc @Ocramius

@Maks3w
Copy link
Member

Maks3w commented Feb 23, 2014

@Ocramius ping

@Ocramius
Copy link
Member

This can be closed - I will provide another PR in some minutes (to develop)

@Maks3w
Copy link
Member

Maks3w commented Feb 23, 2014

@Ocramius Thanks. Alert us when PR become public before :)

Ocramius added a commit to Ocramius/zf2 that referenced this pull request Feb 23, 2014
@Ocramius
Copy link
Member

@Maks3w provided #5858 (2.3 only, but can be fitted for 2.2 as well)

Maks3w added a commit that referenced this pull request Feb 26, 2014
@Maks3w Maks3w closed this Feb 26, 2014
gianarb pushed a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015
…fix/proxy-auto-generation

Deprecate Proxy auto-generation. Close zendframework/zendframework#5198
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants