ProxyManager bugfix #5198
ProxyManager bugfix #5198
Conversation
@Ocramius have a look please |
@blanchonvincent this still dumps all the files to disk (see the |
@Ocramius Hmm I think I don't understand. If you use "write_proxy_files => false", you'll use the EvaluatingGeneratorStrategy ? |
Yes basically :-) |
@Ocramius and I made a mistake ? Sorry Marco, I think I don't where I wrong in this PR :/ |
@blanchonvincent Can you add a description to the PR indicating the problem you encountered, and how you're attempting to solve it, please? When I look at the changes, I have doubts about what you're trying to accomplish, and whether the approach is sound... but mostly due to the fact that I'm unclear what the purpose is. |
@blanchonvincent may I also suggest a dev dependency bump? :) |
@weierophinney I added a fail test case : https://github.com/blanchonvincent/zf2/blob/d08395942f275d32cf2af308d1b9b2044ca4c2c3/tests/ZendTest/ServiceManager/Proxy/LazyServiceFactoryFactoryTest.php#L82 This has been fixed in ProxyManager project : https://github.com/Ocramius/ProxyManager/pull/87/files The problem is when |
@Ocramius what is a dev dependency bump ? a dependence from the ProxyManager project ? |
Yep, basically using 0.5.x for running the tests |
@Ocramius Yep, agree if we can |
@blanchonvincent and @Ocramius -- any news on completing this? or should I close? |
This PR fix a bug (see the fail test case), so maybe can we merge ? cc @Ocramius |
@Ocramius ping |
This can be closed - I will provide another PR in some minutes (to develop) |
@Ocramius Thanks. Alert us when PR become public before :) |
Deprecate Proxy auto-generation. Close #5198
…fix/proxy-auto-generation Deprecate Proxy auto-generation. Close zendframework/zendframework#5198
No description provided.