fixes #5270 #5271

Closed
wants to merge 5 commits into
from

Projects

None yet

4 participants

@steverhoades
Contributor

This fixes issue #5270 where filters isValid returns no data present error when data is set on an aggregate inputfilter.

@Maks3w
Member
Maks3w commented Oct 16, 2013

Hi @steverhoades The PR cannot be automatically merged. Can you merge the most recent master branch in your branch PR?

@EvanDotPro
Member

@steverhoades Please rebase this PR onto the latest upstream master. The commit your PR is based on is over a year old. Also it'll make your life easier if you use a hotfix branch instead of getting your fork's master out of sync with upstream. ;)

@steverhoades
Contributor

Woops. Thought it was a fresh fork, my bad. I'll take care of this shortly.

@steverhoades
Contributor

Ok, 2nd try - did I do that right?

@Maks3w
Member
Maks3w commented Oct 16, 2013

It's mergeable. Thank you

@steverhoades
Contributor

Perfect, sorry about that!

A few comments regarding this commit, I think it would be nice to understand what the purpose of the populate() method is, as It's not abundantly clear to me why this method needs to exist. The same goes for validateInput($input). I went through the commit history but had a hard time extrapolating the details behind this.

I think any dependency on $this->data should be removed from this class entirely, this could possibly make the getUnknown() and hasUnknown() methods irrelevant ...

thoughts?

@weierophinney weierophinney added a commit that referenced this pull request Oct 23, 2013
@weierophinney weierophinney [#5271] CS fixes
- trailing whitespace
- add parameter annotation
- typehint on new parameter
- spaces after operators, comments
- remove extraneous lines in test
fc3cc29
@weierophinney weierophinney added a commit that closed this pull request Oct 23, 2013
@weierophinney weierophinney Merge branch 'hotfix/5271'
Close #5271
Fixes #5270
5d6f0bc
@weierophinney weierophinney added a commit that referenced this pull request Oct 23, 2013
@weierophinney weierophinney Merge branch 'hotfix/5271' into develop
Forward port #5271
a1999ed
@weierophinney weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#5271 from steverhoades… ba41c14
@weierophinney weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#5271] CS fixes
- trailing whitespace
- add parameter annotation
- typehint on new parameter
- spaces after operators, comments
- remove extraneous lines in test
33666f2
@weierophinney weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/5271' 2216b26
@weierophinney weierophinney added a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/5271' into develop 83bf2e2
@Maks3w Maks3w referenced this pull request in zendframework/zend-inputfilter Aug 20, 2015
Merged

Fix missing optional fields should not be validated #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment