This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix Zend\Form\Element\Number $inclusive is always true (Fix for #5549) #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,7 @@ protected function getValidators() | |||
| 'locale' => 'en_US', // HTML5 uses "100.01" format | |||
| )); | |||
|
|
|||
| $inclusive = true; | |||
| $inclusive = false; | |||
There was a problem hiding this comment.
@bakura10 sorry, I mean, I think it's not break BC, it is a default value, in next line, there is a condition if has attributes['inclusive'], then assign with that attribute value. any suggestion ?
There was a problem hiding this comment.
What if inclusive option is not set? The default inclusive then reversed :)
There was a problem hiding this comment.
@bakura10 fixed ;). unit test updated. let me know if I missed something ;)
|
better :) |
Maks3w
added a commit
that referenced
this pull request
Feb 20, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 20, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 20, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5549