Fix Zend\Form\Element\Number $inclusive is always true (Fix for #5549) #5551

Merged
merged 2 commits into from Feb 20, 2014

3 participants

@bakura10 bakura10 and 1 other commented on an outdated diff Nov 27, 2013
library/Zend/Form/Element/Number.php
@@ -48,7 +48,7 @@ protected function getValidators()
'locale' => 'en_US', // HTML5 uses "100.01" format
));
- $inclusive = true;
+ $inclusive = false;
@bakura10
bakura10 added a line comment Nov 27, 2013

Isn't it a BC?

@samsonasik
samsonasik added a line comment Nov 27, 2013

@bakura10 sorry, I mean, I think it's not break BC, it is a default value, in next line, there is a condition if has attributes['inclusive'], then assign with that attribute value. any suggestion ?

@bakura10
bakura10 added a line comment Nov 27, 2013

What if inclusive option is not set? The default inclusive then reversed :)

@samsonasik
samsonasik added a line comment Nov 27, 2013

@bakura10 fixed ;). unit test updated. let me know if I missed something ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bakura10

better :)

@Maks3w Maks3w was assigned by samsonasik Feb 20, 2014
@Maks3w Maks3w merged commit d2e7bf6 into zendframework:master Feb 20, 2014

1 check passed

Details default The Travis CI build passed
@samsonasik samsonasik deleted the samsonasik:fix/inclusive branch Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment