Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused parameters $sm for plugins factory #6393

Closed

Conversation

Projects
None yet
4 participants
@jmleroux
Copy link
Contributor

commented Jun 19, 2014

No description provided.

@DASPRiD

This comment has been minimized.

Copy link
Member

commented Jun 19, 2014

Just for the record: The failing test on PHP 5.6 is not due to this PR.

@jmleroux

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2014

Just for the record: The failing test on PHP 5.6 is not due to this PR.

A problem with fractionnal DateTime in PHP 5.6

@Ocramius

This comment has been minimized.

Copy link
Member

commented Jun 19, 2014

We shouldn't allow failures in 5.6. Please revert the change on .travis.yml
The PR would be merged anyway.

@Ocramius Ocramius added Mvc labels Jun 19, 2014

@jmleroux

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2014

Please revert the change on .travis.yml

done

@ezimuel ezimuel added this to the 2.3.2 milestone Aug 6, 2014

@Ocramius Ocramius closed this in 9b75279 Aug 6, 2014

Ocramius added a commit that referenced this pull request Aug 6, 2014

@Ocramius

This comment has been minimized.

Copy link
Member

commented Aug 6, 2014

@jmleroux I removed the commits related to .travis.yml and merged the PR manually. Thanks!

@Ocramius Ocramius self-assigned this Aug 6, 2014

@jmleroux jmleroux deleted the jmleroux:patch-ViewHelperManagerFactory branch Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.