Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Remove trailing whitespaces #6487

Merged
merged 1 commit into from Jul 28, 2014
Merged

Remove trailing whitespaces #6487

merged 1 commit into from Jul 28, 2014

Conversation

rahuldroy
Copy link
Contributor

No description provided.

@eddiejaoude
Copy link
Contributor

Failing tests...(I couldn't see the re-run build link on TravisCI - as failing test was related to date time, worth a re-test or test needs improving to avoid race conditions)

There were 2 failures:
1) ZendTest\Feed\Reader\Entry\AtomTest::testGetsDateCreatedWithFractional
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
 DateTime Object (
-    'date' => '2009-03-07 08:03:50.000000'
+    'date' => '2009-03-07 08:03:50.800000'
     'timezone_type' => 2
     'timezone' => 'Z'
 )
/home/travis/build/zendframework/zf2/tests/ZendTest/Feed/Reader/Entry/AtomTest.php:115
2) ZendTest\Feed\Reader\Entry\AtomTest::testGetsDateModifiedWithFractional
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
 DateTime Object (
-    'date' => '2009-03-07 08:03:50.000000'
+    'date' => '2009-03-07 08:03:50.800000'
     'timezone_type' => 2
     'timezone' => 'Z'
 )
/home/travis/build/zendframework/zf2/tests/ZendTest/Feed/Reader/Entry/AtomTest.php:148
FAILURES!
Tests: 1368, Assertions: 1487, Failures: 2, Incomplete: 11, Skipped: 10.

@Ocramius
Copy link
Member

@eddiejaoude these are unrelated to this particular issue, and we are aware of them already (for 5.6)

@Ocramius Ocramius self-assigned this Jul 28, 2014
@Ocramius Ocramius added the bug label Jul 28, 2014
@Ocramius Ocramius added this to the 2.3.2 milestone Jul 28, 2014
@eddiejaoude
Copy link
Contributor

@Ocramius ok 😄

@Ocramius Ocramius merged commit cb91dde into zendframework:develop Jul 28, 2014
Ocramius added a commit that referenced this pull request Jul 28, 2014
@Ocramius
Copy link
Member

Merged also in master after a cherry-pick. Thanks!

@rahuldroy
Copy link
Contributor Author

@Ocramius YAY!!!! My first PR for ZF!!! Please don't hesitate to contact me
for easy stuff like this. I'll happily do it :).

Thanks,
Rahul
On 28 Jul 2014 17:57, "Marco Pivetta" notifications@github.com wrote:

Merged also in master after a cherry-pick. Thanks!


Reply to this email directly or view it on GitHub
#6487 (comment).

@Ocramius
Copy link
Member

@rahuldroy you can poke me on IRC anytime: I can always give you stuff to do :-)

gianarb pushed a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants