Replace Zend\Autoload with Composer #164
Conversation
all modules are loaded with Composer PSR-4 and classmap autoload
| @@ -4,20 +4,6 @@ | |||
| $loader = include 'vendor/autoload.php'; | |||
There was a problem hiding this comment.
I would even go as far as to just include vendor/autoload.php in public/index.php instead of including this file.
What do you think?
Like this here: localheinz@637fb36
(Sorry, just wanted to open a PR with that, then saw that you already had opened one 3 hours ago 😉)
There was a problem hiding this comment.
In my opinion this is a good improvement! :) Would you push it in my feature branch?
There was a problem hiding this comment.
Here you are: https://github.com/gianarb/zf-web/pull/1!
Enhancement: Simplify autoloader initialization
| "autoload": { | ||
| "psr-4": { | ||
| "Api\\": "./module/Api", | ||
| "Application\\": "./module/Application/src/Application", |
There was a problem hiding this comment.
how about "Application\": "./module/Application/src/" ?
There was a problem hiding this comment.
as psr-4, we don't need too deep folder imo
There was a problem hiding this comment.
In this step I keep same folding :)
maybe module/Application/src/Application in my opinion is a standard ZF module folder now
There was a problem hiding this comment.
why the dots? i think all can go away? 👴
There was a problem hiding this comment.
perhaps that module folder has to go and give way to just src
There was a problem hiding this comment.
ah yes yes :) would you send me a PR?
2015-02-21 19:50 GMT+01:00 Luis Cordova notifications@github.com:
In composer.json
#164 (comment):@@ -9,5 +9,34 @@
"php": ">=5.3.3",
"zendframework/zendframework": "2.2.",
"zendframework/zendservice-recaptcha": "2.0."
- },
- "autoload": {
"psr-4": {"Api\": "./module/Api","Application\": "./module/Application/src/Application",why the dots? i think all can go away? [image: 👴]
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zf-web/pull/164/files#r25124488.
Gianluca Arbezzano
www.gianarb.it
There was a problem hiding this comment.
I will send a PR if at least @Ocramius or some other maintainer gives me green light
|
I like, though I'm not aware of the deployment process involved. 👍 |
|
Related to #163 |
gianarb
changed the title
|
@weierophinney are you interested? |
|
@gianarb |
|
👍 |
|
@gianarb need rebase |
|
Fixed with e8a788c Thanks to @gianarb and @localheinz ! |
|
Thanks |
all modules are loaded with Composer PSR-4 and classmap autoload
This project have not tests, I tried several parts of it but I don't know all system.. This is a good starting point