Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

Serialized DateTime includes fractions of seconds since 5.6.0beta4 #385

Merged
merged 1 commit into from Jun 25, 2014

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Jun 19, 2014

https://github.com/php/php-src/blob/php-5.6.0beta4/NEWS

Date: Fixed bug #67308 (Serialize of DateTime truncates fractions of second). (Adam)

1) Zend_Ldap_ConverterTest::testToLdapSerialize with data set #2 ('O:8:"DateTime":3:{s:4:"date";s:19:"1970-01-01 00:00:00";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}', DateTime)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'O:8:"DateTime":3:{s:4:"date";s:19:"1970-01-01 00:00:00";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}'
+'O:8:"DateTime":3:{s:4:"date";s:26:"1970-01-01 00:00:00.000000";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}'

@mhujer
Copy link
Contributor Author

mhujer commented Jun 19, 2014

No tests are failing on PHP 5.6, but The it returns code 139 "php runalltests.php" exited with 139. (google search suggests, that it's some segfault - maybe opcache/xdebug related)

@froschdesign froschdesign added this to the 1.12.8 milestone Jun 25, 2014
froschdesign added a commit that referenced this pull request Jun 25, 2014
Serialized DateTime includes fractions of seconds since 5.6.0beta4
@froschdesign froschdesign merged commit b5be90c into zendframework:master Jun 25, 2014
@froschdesign
Copy link
Member

Thanks!

@mhujer mhujer deleted the datetime56 branch June 25, 2014 09:41
@froschdesign
Copy link
Member

Last result: 'The command "php runalltests.php" exited with 134.'

@froschdesign
Copy link
Member

@mhujer
Any ideas?

@mhujer
Copy link
Contributor Author

mhujer commented Jun 25, 2014

As the Travis build is run with dev versions of everything, I suggest waiting for next PHP 5.6 beta/RC and see if it's fixed. In the meanwhile, we can mark 5.6 as an allowed failure.

PHP 5.6.0beta4 (cli) (built: Jun 12 2014 14:13:53) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.6.0-dev, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.2.5, Copyright (c) 2002-2014, by Derick Rethans

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants