This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[2.1] Update library/Zend/View/Helper/HeadScript.php #2208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What this does: This fix would result in that the 3rd param is the conditional string Reason: I would like to see the same pattern used for this method as for HeadLink::_call (eg. appendStylesheet, offsetSetStylesheet, prependStylesheet and setStylesheet)
|
@erik-landvall Please see the failure report linked by @travisbot -- this introduces a regression, as you're changing argument order by adding the new argument between existing arguments. The new argument should be an optional final argument to the pseudo-methods. Also, please create test cases. |
ghost
assigned 
|
For this method to be able to follow the same pattern as the ones in HeadLink I would argue that the arguments should be in this order instead. I open a new pull request in a more correct fashion later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
This fix would result in that the 3rd param is the conditional string
Reason:
I would like to see the same pattern used for this method as for HeadLink::_call (eg. appendStylesheet, offsetSetStylesheet, prependStylesheet and setStylesheet)