This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed FileGenerator::setUses() to allow passing in array of strings. #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows setUses() to be called with an array of string 'uses'. This makes it easier to call when the 'as' part is not needed.
In my use case I had an existing array of strings that I wanted to pass directly to setUses().
This patch actually allows mixing of strings (without the 'as') and arrays of the form array('use', 'as') in the array that's passed to setUses(). This is demonstrated in testSetUsesWithString().