This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Session Container Mismatch & Version Compare fixes for 5.3.3 #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2013 07:14
…ntainer to allow traversable added new test to test old behavior
|
Build passed :) |
|
This PR will close #3700 |
ghost
assigned 
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The changes with the new Zend\Stdlib\ArrayObject caused an overall break in Zend\Session\Container when the code was not tested in isolation (meaning there was previous Containers in the session). This is because they were of type \ArrayObject causing an object mismatch; in general the logic was flawed because we should only care if it is Traversable since the main contract is pretty much an array. Overall this causes an upgrade issue for people upgrading on production. The current workaround is to remove all sessions.
Secondly; Zend\Stdlib\ArrayObject and friends that provide functionality for 5.3.4+ accidentally matches builds from distribution patch fixes; for example:
var_dump(version_compare('5.3.3-7+squeeze14', '5.3.3'))
int(1)
When you'd likely expect it to be of int(0). To solve this version compare must be made against the higher version:
var_dump(version_compare('5.3.3-7+squeeze14', '5.3.4'))
int(-1)