This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed some Errors/Warnings #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setOptions to map 'cookie_httponly' well to setCookieHttpOnly
|
@marc-mabe Could you provide us the link to the Travis job? |
|
@ralphschindler This PR change some lines in Zend\Db |
| foreach ($options as $key => $value) { | ||
| // translate key from underscore_separated to TitleCased | ||
| $methodKey = str_replace(' ', '', ucwords(str_replace('_', ' ', $key))); | ||
| $method = 'set' . $methodKey; | ||
| if (in_array($method, $methods)) { | ||
| if (method_exists($this, $method)) { |
There was a problem hiding this comment.
I'm not sure if, from the performance perspective, is best extract the methods first and then do 'N' access to the cache (array) rather than test if the method_exists 'N' times
There was a problem hiding this comment.
I changed that because of the option "cookie_httponly" which maps to the method [get|set]CookieHttpOnly.
The simple in_array check doesn't work because of case sesitivity.
(Before this change it maps to [get|set]CookieHTTPOnly)
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.