Zend\I18n\View\Helper\DateFormat - Fallback to date.timezone instead of system timezone.

[dmitrybelyakov]

Fallback to date.timezone instead of system timezone.

If we do not explicitly set timezone on DateFormat, it passes null value as timezone to IntlDateFormatter, that should fallback to date.timezone but doesn't. So we better do it ourselves.

Here's a test to demonstrate the bug:

//set timezone to UTC
ini_set('date.timezone', 'UTC');

$now = new \DateTime;
$now->setTimezone(new \DateTimeZone('UTC'));
$expected = $now->format('g:i A');

//format
$helper = $this->getLocator()->get('Zend\I18n\View\Helper\DateFormat');
$formatted = $helper->__invoke(
    $now,
    \IntlDateFormatter::NONE,
    \IntlDateFormatter::SHORT,
    'en_US'
);

$this->assertEquals($expected, $formatted);

[travisbot]

This pull request fails (merged 0444e61 into 89eaf41).

[travisbot]

This pull request fails (merged c09afbe into 89eaf41).

[weierophinney]

CS: need a space between "if" and opening paren.

[dmitrybelyakov]

Fixed, thanks :) Wonder if this could go into 2.0 because we really need that.

[travisbot]

This pull request passes (merged 7c5e5ab into 89eaf41).

[DASPRiD]

Going to technically review it later today.

[dmitrybelyakov]

Thanks Ben!