This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Pass the right validator options #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not give the required result. It gives the isset result which is a boolean true or false. (isset($this->attributes['min'])) ?: 0 This does work. It adds the value as expected. (isset($this->attributes['min'])) ? $this->attributes['min'] : 0,
weierophinney
added a commit
that referenced
this pull request
Sep 4, 2012
- README.md, ParameterReflection, and Version needed to be reverted to release branch in order to merge cleanly.
|
Merged to 2.0.0, 2.0.1, and master. |
fabiocarneiro
pushed a commit
to fabiocarneiro/zend-form
that referenced
this pull request
Feb 4, 2015
Same issue as with zendframework/zendframework#2293 It passes the value of isset and not the min/step attribute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not give the required result. It gives the isset result which is a boolean true or false.
(isset($this->attributes['min'])) ?: 0
I used a var_dump($options) in Zend\validator\GreatherThan.php
var_dump with min value 0:
array (size=2)
'min' => boolean true
'inclusive' => boolean true
var_dump with min value 5:
array (size=2)
'min' => boolean true
'inclusive' => boolean true
This does work. It adds the value as expected.
(isset($this->attributes['min'])) ? $this->attributes['min'] : 0,
var_dump with min value 0:
array (size=2)
'min' => int 0
'inclusive' => boolean true
var_dump with min value 5:
array (size=2)
'min' => int 5
'inclusive' => boolean true