Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

README-GIT update with optional pre-commit hook #2332

Merged
merged 1 commit into from
Sep 13, 2012

Conversation

cgmartin
Copy link
Contributor

Pre-commit hook instructions for checking code style with php-cs-fixer.

Pre-commit hook instructions for checking code style with php-cs-fixer.
@b-durand
Copy link
Contributor

You should test if php-cs-fixer is available in the hook IMHO.

I think that can add the curl command to download php-cs-fixer in the comment.

@cgmartin
Copy link
Contributor Author

@b-durand is something like this what you have in mind for the testing if php-cs-fixer is available? https://gist.github.com/3452087

I'm hesitant to include the curl command in case the install procedures ever change. My preference would be to point them to the full install instructions, and let it be maintained there.

Thanks for the feedback

@weierophinney weierophinney merged commit c3b9f25 into zendframework:master Sep 13, 2012
@ghost ghost assigned weierophinney Sep 13, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants