Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

[hotfix/ZF-9289] Zend_Filter_InputFilter #273

Closed

Conversation

thomasweidner
Copy link
Contributor

  • fixed incorrect validation errors on custom NotEmpty validator

- setting ALLOW_EMPTY should not ignore specific NotEmpty rules
…Y should not ignore specific NotEmpty rules"

This reverts commit 25a4c41.
- fixed incorrect validation errors on custom NotEmpty validator

Note: Up-ported ZF1 commit. Unittests fail on both releases for me so I
dont know if this is intentional or an still existing issue
@thomasweidner
Copy link
Contributor Author

Note: I up-ported the related ZF1 commit. Unittests fail on both releases for me so I
dont know if this is intentional by my environment or an still existing issue

@weierophinney
Copy link
Member

It looks like the logic for determining whether allow_empty is okay is broken when the first element in the data array doesn't have validators -- it's simply not applied to any other items. Additionally, it looks like the logic may be miscalculating the number of data elements needing validation. If I can fix it, do we need to backport to ZF1?

@weierophinney
Copy link
Member

Found the issue, and I've patched, merged, and pushed. Let me know if you would like a patch for backporting to ZF1.

@thomasweidner
Copy link
Contributor Author

In my opinion a backport would be great because otherwise we would have known problems within ZF1
Thank you in advice

@weierophinney
Copy link
Member

Backport is now in both trunk and the 1.11 release branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants