Adding cookie route. Going to open PR for comments. #2772
Conversation
…viously string(5.00) did not equal int(5) after it was parsed
[ZF2-550] Removed type check so that string("5.00") is recognized as equal to int(5) to validate it is a float
…o feature/view-helper-headlink-rel
…/cgmartin/zf2 into feature/filter-validator-manager-factories
…-mabe/zf2 into feature/serializer-msgpack
Conflicts: library/Zend/I18n/Validator/Float.php tests/ZendTest/I18n/Validator/FloatTest.php
|
I forgot to mention in the PR that i'd like opinions on this approach or if there is a better way of doing it. |
ghost
assigned 
|
First of all, you should review PSR-1 (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md) and PSR-2 (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md), so your code complies with the coding standard. On a first look, there are also some architectural things, which I will comment on within the next 24 hours. |
|
Thanks DASPRID. I'll go back and change my code to comply. Just wanted someone like yourself to comment with architectural advice to see if this is even useful or if there are other options for accomplishing the same thing. Thanks for you willingness to help. |
|
Hey DASPRiD, |
|
Hi @starJammer – wonder if you could ping me in IRC (#zftalk.dev on freenode) to discuss your implementation. |
|
Hey DASPRiD, Sure. What times are you available. This week won't be good for me until maybe Friday night. Thanksgiving is coming up in the usa and I'll be enjoying festivities on Thurs. |
|
@starJammer and @DASPRiD -- have you had a chance to discuss this yet? Would like to see some progress. :) |
|
@DASPRiD I'll be online during the day tomorrow if you'd like. I'll be on the irc channel tomorrow at 12pm EST time. |
Conflicts: library/Zend/Code/Scanner/ClassScanner.php library/Zend/Code/Scanner/PropertyScanner.php
|
Not sure on what I did here. I probably should not have updated my cookie branch with the latest changes from master. |
|
@DASPRiD are the new changes @starJammer introduced based on your IRC discussion? is this ready to merge? |
|
No we haven't met yet @weierophinney. I ran my code through a prs tool and changed some code based on some bugs I encountered. |
|
Closed after discussion with DASPRiD. Conclusion : At the moment though, this functionality isn't something that is necessary in the core. |
Creating a cookie route that will route you according to cookies you have set or that you don't have set.
I was inspired by the approach taken in www.yiibu.com
To understand you might have to delete the cookies this site sets several times.
They route you to a 'setup' page if you don't have a certain cookie. Otherwise, they let you pass on through to the normal page you want.