Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

[Router] no need to correct ~ in the path encoding #3393

Closed
wants to merge 1 commit into from

3 participants

@Tobion

The ~ is not encoded by rawurlencode, so we don't need to decode it again.

@Tobion Tobion no need to correct ~ in the path encoding
The ~ is not encoded by rawurlencode, so we don't need to decode it again.
bdceb0e
@Maks3w
Collaborator

Please add a test case to avoid regressions

@weierophinney

@Maks3w This is actually already covered in a unit test case, surprisingly, and making the change allows the test to continue to pass.

@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3393'
Close #3393
2bbaec4
@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3393' into develop
Forward port #3393
94ca732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 9, 2013
  1. @Tobion

    no need to correct ~ in the path encoding

    Tobion authored
    The ~ is not encoded by rawurlencode, so we don't need to decode it again.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  library/Zend/Mvc/Router/Http/Segment.php
View
2  library/Zend/Mvc/Router/Http/Segment.php
@@ -58,7 +58,7 @@ class Segment implements RouteInterface
'%3D' => "=", // sub-delims
'%40' => "@", // pchar
// '%5F' => "_", // unreserved - not touched by rawurlencode
- '%7E' => "~", // unreserved
+// '%7E' => "~", // unreserved - not touched by rawurlencode
);
/**
Something went wrong with that request. Please try again.