Allow to set arbitrary status code for Exception strategy #3421
Conversation
| $e->setResponse($response); | ||
| } | ||
| $response->setStatusCode(500); | ||
| $response->setStatusCode($response->getStatusCode()); |
There was a problem hiding this comment.
This line can be completely skipped, no?
There was a problem hiding this comment.
HA. Yeah, you're right =).
| @@ -158,9 +158,10 @@ public function prepareExceptionViewModel(MvcEvent $e) | |||
| $response = $e->getResponse(); | |||
| if (!$response) { | |||
| $response = new HttpResponse(); | |||
| $response->setStatusCode(500); | |||
| $e->setResponse($response); | |||
| } | |||
There was a problem hiding this comment.
I would test for an empty status code as well; if it's empty, we want to set it. The problem, however, is that the status code is never empty by default; it defaults to 200. Perhaps we could test for a "200" status code, and reset in that case? or allow injecting a list of "allowed" exception status codes and/or a default to use in exceptions when the current code is not in that list?
There was a problem hiding this comment.
For error it's between 400 and 599. We could add a test on that and set it to 500 if it's outside those bounds.
But isn't it the task of other listeners or classes to set the appropriate error code ?
ghost
assigned 
While working on ZfrRest, I realized Exception strategy always set the response status code to 500, even if another status code was set after an error (for instance in another listener).
This PR set 500 status code if the Response did not exist, and if it already exists, it sets it to the set status code, hence not always overriding it.