This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[2.1] fixed tons of missing/wrong use statements #3496
Merged
weierophinney
merged 7 commits into
zendframework:develop
from
marc-mabe:hotfix/missingUseStatements
Jan 21, 2013
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d1be72
Added missing use statements in Zend\Stdlib
marc-mabe 1f32598
Added missing 'use ArrayIterator' and fixed renamed Cookie -> SetCook…
marc-mabe 5e1e560
Added missing 'use Zend\Uri\UriFactory' in Zend\Http\Header\SetCookie
marc-mabe 581857a
fixed RuntimeException -> Exception\RuntimeException in Zend\Log\Writ…
marc-mabe 96c5f5d
Added missing 'use ArrayIterator' and 'use Zend\Session\Exception' in…
marc-mabe 0ab71eb
Added missing 'use Zend\Stdlib\ResponseInterface' in Zend\Test\PHPUni…
marc-mabe c7b9777
fixed FaultException -> Exception\FaultException in Zend\XmlRpc\Clien…
marc-mabe File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not add a use just for something that is in a comment (at least someone told me not to do one day).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bakura10 We often do this to make the comments more readable and coherent.
Since phpdoc and most ides resolve them based on the imports/namespace,
they continue to document correctly. Since PHP does not expand an import or
try to autoload it unless the code actually references it, it's a no-op for
the engine.
On Saturday, January 19, 2013, Michaël Gallego wrote:
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this we miss the possibility of scan
use
statements for detect direct dependenciesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally
ResponseInterface
is used here : https://github.com/marc-mabe/zf2/blob/c7b97774ce68ea0472accbd393ff5f938ebb2c57/library/Zend/Test/PHPUnit/Controller/AbstractControllerTestCase.php#L294