Fixed method that removed part from parts in Mime\Message

[RWOverdijk]

Now using current() to get the single mime part so we don't unset it for future use.

[Maks3w]

Please add a test case

[RWOverdijk]

How do you want me to test that it's working? It's now not removing parts. Do you want me to write a check to see if parts were removed?

[Maks3w]

Yes, because without test the risk of to have a regression is high. I.e someone do some PR for optimization and opts for change your current() again

[weierophinney]

@RWOverdijk I agree with @Maks3w -- incremental improvements need tests so we can ensure we don't introduce regressions later. I realize that the MIME component is not well-tested -- but with improvements like this, we can add tests, and make it more solid going forward.

And many thanks in advance!

[RWOverdijk]

I'll add a test when I find a small bit of time. Currently I have no time.

On 5 feb. 2013, at 17:33, weierophinney notifications@github.com wrote:

@RWOverdijk I agree with @Maks3w -- incremental improvements need tests so we can ensure we don't introduce regressions later. I realize that the MIME component is not well-tested -- but with improvements like this, we can add tests, and make it more solid going forward.

And many thanks in advance!

—
Reply to this email directly or view it on GitHub.

[weierophinney]

I've written a test and included it on merge.

[RWOverdijk]

Thanks. Sorry for not adding the test. I'll add it next time :)