This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/case sensitive console #4005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| fwrite($this->adapter->stream, 'y'); | ||
|
|
||
| $confirm = new Confirm("ZF2 is the better framework ?"); |
There was a problem hiding this comment.
"Is ZF2 the best framework?" ;)
There was a problem hiding this comment.
thank you :)
weierophinney
added a commit
that referenced
this pull request
Mar 12, 2013
…onsole Hotfix/case sensitive console
ghost
assigned
curious-eyes
pushed a commit
to curious-eyes/zf2
that referenced
this pull request
Mar 18, 2013
- trailing whitespace
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
…ent/hotfix/case-sensitive-console Hotfix/case sensitive console
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
- trailing whitespace
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After write the tests on Console, i see a bug on the sensitive case.
It was possible to configure sensitive case (or not sensitive), but the reading was only always insensitive.
This bug is fix and i had tests on the Prompt\Confirm.
I make a consistency between console reading char too and delete a useless loop on the reading char which are already done in the console adapter.