This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix BC break in HTTP client resetParameters signature #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Even though the signature was technically still BC compatible, any extension that did not define the second optional parameter would raise a fatal error. - Solution was to remove the argument, and check for it with func_num_args/func_get_arg.
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zendframework/ZendOAuth#11 for an example of the consequences of the change.
This PR simply comments out the parameter (by using a comment, we indicate it's expected), and uses
func_num_args()andfunc_get_arg()to sniff for it.