Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basketball GM - make rookie contracts more sensible #372

Open
Dylan1496 opened this issue Mar 25, 2021 · 7 comments
Open

Basketball GM - make rookie contracts more sensible #372

Dylan1496 opened this issue Mar 25, 2021 · 7 comments

Comments

@Dylan1496
Copy link

In the NBA, rookie contracts tend to be in the range of .5 - 8 M AAV for a 2-3 year deal. However, if you have a really good rookie enter the draft then they could ask for a lot more than that. For instance, here is an example from a save in 2024:
image

What I suggest is to change the contract code so that rookies get lower contracts, as it would not make sense for rookies to make big money without proving themselves, first.

@dumbmatter
Copy link
Member

This is just with the hard cap enabled, right? Because with the default settings, there is a rookie contract scale, similar to the NBA.

If there was no rookie contract scale, rookies would probably get pretty huge contracts. That's what happened back in the 90s and led to the creation of the rookie contract scale.

@Dylan1496
Copy link
Author

This was taken with default settings (which has the hard cap enabled). All I can see with regards to rookies is contract length based on the round taken, which is [3,2].

@dumbmatter
Copy link
Member

Default is hard cap disabled and rookies are automatically signed to rookie scale contracts. Try it in a new league.

@Dylan1496
Copy link
Author

Okay, when I run it in a new league with hard cap disabled the contracts make more sense. I have, for example, a 58 overall making 7.5 million for 3 years.
So I guess then the solution would be to always run hard cap, or have an option that if hard cap is enabled to also have an option to set a maximal rookie contract.

@dumbmatter
Copy link
Member

Yeah, it would be a good idea to add a separate setting for whether or not to use a rookie contract scale, independent of the hard cap setting. Also would be good to make the rookie contract scale customizable.

@luso97
Copy link
Contributor

luso97 commented Apr 13, 2021

Anyone working on this?

@dumbmatter
Copy link
Member

No, you are welcome to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants