Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More curves please #41

Open
MoezGholami opened this issue Apr 7, 2019 · 4 comments
Open

More curves please #41

MoezGholami opened this issue Apr 7, 2019 · 4 comments
Labels
elliptic curve enhancement New feature or request

Comments

@MoezGholami
Copy link

Hi there,
It would be good if you implement more curves. Mainly, I'm speaking about secp521r1 as almost all SSL libraries have implemented it..
I wish I was not so new to Rust and ECC and I could contribute to this project. Nevertheless, I like the Gotham city project and I would appreciate a lot if some more trusted curves are implemented here.

@omershlo omershlo added elliptic curve enhancement New feature or request labels Apr 7, 2019
@omershlo
Copy link
Contributor

omershlo commented Apr 7, 2019

Hi @MoezGholami ,
Thanks for this suggestion. secp521r1 can be interesting addition.
Do you happen to know a Rust implementation of this EC?

@MoezGholami
Copy link
Author

I did a quick search but couldn't find any.

@omershlo
Copy link
Contributor

omershlo commented Apr 7, 2019

Any cpp libraries maybe?
Curv uses existing implementations of ECs and build on top of them. Writing the low level code of secp521r1 is completely other game. We need to find a good library for the basic secp521r1 and than it can be on-boarded.

@MoezGholami
Copy link
Author

MoezGholami commented Apr 7, 2019

Omer, I found the openssl implementation of it here. However, there is a problem with this specific curve which make me to take my word back; according to this, it is not used at least for now. (The post is not new but it the recent comments are endorsing it).
According to that post secp384r1 seems a better choice. I tried to look its implementation up, I guess one example is this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elliptic curve enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants