Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I get the full private key? #20

Closed
freehere107 opened this issue Apr 26, 2019 · 5 comments
Closed

Can I get the full private key? #20

freehere107 opened this issue Apr 26, 2019 · 5 comments

Comments

@freehere107
Copy link

No description provided.

@omershlo
Copy link
Contributor

Yes, working on it as we speak :)

@omershlo
Copy link
Contributor

I will let you know when I push the code

@omershlo
Copy link
Contributor

@freehere107 This seems to be problematic at the moment : Technically it is very easy but security wise it creates an issue since now we will have API call to extract the secret share of party two. The code is designed in such way that the secret shares are never exposed and all operations on them are done locally (for example you can ask to refresh the private key but you will not get the new key as output, just an object of master key with the new key).

Until we find a solution you can do one of the following:

  1. It is currently possible to serialize master keys - you can serialize them and take the secret shares. This is not supposed to be supported in the future (see Eliminate SerDes of PrivateShare and MasterKeys #21 )
  2. see this test : https://github.com/KZen-networks/kms-secp256k1/blob/master/src/ecdsa/two_party/test.rs#L46 . Now all operations are possible but one party will run both master keys roles locally

I am open for suggestions as well

@freehere107
Copy link
Author

freehere107 commented Apr 28, 2019

I try it. https://github.com/KZen-networks/kms-secp256k1/blob/master/src/ecdsa/two_party/test.rs#L46 There is a problem, MasterKey1 private field scope is private.It's not possbile to to_encrypted_segment from parity1

@omershlo
Copy link
Contributor

Can you elaborate more? if you want to use the segmented encryption it should be possible on private field. What is the code you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants