Todo app example #16
Todo app example #16
Conversation
| case None => Right(()) | ||
| } | ||
| ) | ||
| _ <- SqlQueryT.liftQuery[ErrorOrResult, Unit]( |
There was a problem hiding this comment.
Ça serait bien d'avoir des exemples où les résultats servent (sont pas discarded), là c'est jamais le cas du coup ça illustre pas trop les avantages de composition.
| environment: | ||
| PGDATA: data | ||
| ports: | ||
| - 5432:5432 |
There was a problem hiding this comment.
Si la DB ne sert que à l'autre container, pas besoin d'exposer le port, à condition de mettre un link approprié
There was a problem hiding this comment.
Non la todo app tape directement dessus. En plus adminer ne me convainc pas vraiment, je vais l'enlever je pense.
There was a problem hiding this comment.
Si c'est accès par un autre container, pas besoin d'exposer les ports sur l'hôte
|
|
||
| private def builder[B]( | ||
| bodyParser: BodyParser[B] | ||
| ): ActionBuilder[ConnectedUserRequest, B] = |
There was a problem hiding this comment.
Il y a t'il réellement besoin d'un ActionBuilder pour ça ?
There was a problem hiding this comment.
Je voulais éviter un empilement d'actions sur les endpoints.
stankoua
force-pushed
the
task/todo-app-example
branch
from
18641d9
to
9b5a246
Compare
stankoua
force-pushed
the
task/play-sql-module
branch
from
40c7d18
to
d1ae7a2
Compare
stankoua
force-pushed
the
task/play-sql-module
branch
from
0ee3491
to
bb64772
Compare
stankoua
force-pushed
the
task/play-sql-module
branch
from
bb64772
to
76896b0
Compare
stankoua
force-pushed
the
task/play-sql-module
branch
from
ed4da4c
to
a9c80af
Compare
stankoua
force-pushed
the
task/todo-app-example
branch
from
9b5a246
to
92e7191
Compare
- Add more checks for POST actions - Better business case error handling - Add route to list todos - Add postman collection for api usage
stankoua
force-pushed
the
task/todo-app-example
branch
from
92e7191
to
59dc4e2
Compare
Pull Request Checklist
Purpose
This PR aim is to add an example so that newcomers could grasp more easily how the query monad could be use on a real project.