Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build the project for Scala 2.11 #19

Merged
merged 4 commits into from
Nov 30, 2018

Conversation

guilgaly
Copy link
Contributor

@guilgaly guilgaly commented Nov 29, 2018

Pull Request Checklist

  • Have you read through the contributor guide?
  • Have you added tests for any changed functionality?

Purpose

  • Cross-build the project to Scala 2.11 (for users still on 2.11)
  • Also updates SBT version as well as project dependencies

Background Context

N/A

References

N/A

@guilgaly guilgaly self-assigned this Nov 29, 2018
@guilgaly guilgaly force-pushed the sbt-cross-build branch 2 times, most recently from 760e18d to 818b8a6 Compare November 29, 2018 13:48
@guilgaly guilgaly changed the title Cross-build the project to different Scala versions Cross-build the project for Scala 2.11 Nov 29, 2018
@guilgaly guilgaly mentioned this pull request Nov 29, 2018
2 tasks
Copy link
Collaborator

@stankoua stankoua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me.

@@ -91,7 +91,7 @@ class TodoController(
ConnectedAction.async { implicit request =>
check(login) {
val query = for {
- <- SqlQueryT.fromQuery[ErrorOrResult, Todo](
_ <- SqlQueryT.fromQuery[ErrorOrResult, Todo](
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@stankoua stankoua merged commit 7918416 into zengularity:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants