* 🐛 fix #213 list notation always doing {*} (#217)

* ✅ Add a test for bug #213 * 🐛 fix #213 list notation always doing {*}, improve tests
zenika-open-source · Jan 16, 2018 · 2e69868 · 2e69868
1 parent 3083de7
commit 2e69868
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/packages/immutadot/src/path/apply.js b/packages/immutadot/src/path/apply.js
@@ -116,7 +116,7 @@ const apply = operation => {
           const newObj = copy(curObj, false)
           let noop = true
 
-          const listProps = allProps ? Object.keys(newObj) : propValue
+          const listProps = propType === allProps ? Object.keys(newObj) : propValue
 
           for (const listProp of listProps) {
             const [iNoop] = walkPath(newObj, curPath, [[prop, listProp], ...pathRest], true)

diff --git a/packages/immutadot/src/path/apply.spec.js b/packages/immutadot/src/path/apply.spec.js
@@ -169,6 +169,7 @@ describe('path.apply', () => {
             'prop2': { val: 6 },
             'prop{3}': { val: 6 },
             '"prop4"': { val: 4 },
+            'prop5': { val: 5 },
           },
           other: {},
         })
@@ -180,6 +181,7 @@ describe('path.apply', () => {
           'prop2': { val: 5 },
           'prop{3}': { val: 5 },
           '"prop4"': { val: 3 },
+          'prop5': { val: 5 },
         },
         other: {},
       },
@@ -242,4 +244,26 @@ describe('path.apply', () => {
       'nested.prop',
     )
   })
+
+  it('should initialize unknown props in a list', () => {
+    immutaTest(
+      input => {
+        const output = inc(input, 'nested.{prop1,prop2}.val')
+        expect(output).toEqual({
+          nested: {
+            prop1: { val: 6 },
+            prop2: { val: 1 },
+          },
+          other: {},
+        })
+        return output
+      },
+      {
+        nested: { prop1: { val: 5 } },
+        other: {},
+      },
+      'nested.prop1.val',
+      'nested.prop2.val',
+    )
+  })
 })