🐛 fix #72 unnecessary object copies

src/array/convertArrayMethod.js

@@ -1,4 +1,5 @@
 import convert from '../util/convert'
+import isArray from 'lodash/isArray'
 import toArray from 'lodash/toArray'
 
 /**
@@ -8,12 +9,13 @@ import toArray from 'lodash/toArray'
  * @param {string} method Array method name.
  * @return {function} Returns the wrapped function.
  * @see {@link util.convert|convert} for more information.
+ * @see {@link https://lodash.com/docs#isArray|lodash.isArray} for more information.
  * @see {@link https://lodash.com/docs#toArray|lodash.toArray} for more information.
  * @since 0.2.0
  * @private
  */
 export default method => convert((array, ...args) => {
-  const newArray = toArray(array)
+  const newArray = isArray(array) ? array : toArray(array)
   newArray[method](...args)
   return newArray
 })

src/array/remove.js

@@ -1,5 +1,5 @@
-import _remove from 'lodash/fp/remove'
-import { convertLodashFp } from '../util/convert'
+import _remove from 'lodash/remove'
+import convert from '../util/convert'
 
 /**
  * Replaces an array removing elements that predicate returns truthy for from the former array.
@@ -13,5 +13,8 @@ import { convertLodashFp } from '../util/convert'
  * @see {@link https://lodash.com/docs#remove|lodash.remove} for more information.
  * @since 0.2.0
  */
-const remove = convertLodashFp(_remove)
+const remove = convert((array, predicate) => {
+  _remove(array, predicate)
+  return array
+})
 export default remove

src/array/remove.spec.js

@@ -11,8 +11,4 @@ describe('Remove', () => {
     expect(final).toEqual({ nested: { prop: [1, 2] } })
     expect(original).toEqual({ nested: { prop: [1, 2, 3] } })
   })
-
-  it('should replace deep undefined with array', () => {
-    expect(remove(undefined, 'nested.prop', () => true)).toEqual({ nested: { prop: [] } })
-  })
 })

src/object/assign.js

@@ -1,5 +1,5 @@
-import _assign from 'lodash/fp/assign'
-import { convertLodashFp } from '../util/convert'
+import _assign from 'lodash/assign'
+import convert from '../util/convert'
 
 /**
  * Assigns own enumerable string keyed properties of source objects to the
@@ -15,5 +15,5 @@ import { convertLodashFp } from '../util/convert'
  * @see {@link https://lodash.com/docs#assign|lodash.assign} for more information.
  * @since 0.1.12
  */
-const assign = convertLodashFp(_assign)
+const assign = convert(_assign)
 export default assign

src/util/convert.js

@@ -29,6 +29,7 @@ export default convert
  * @return {function} Returns the wrapped function.
  * @see {@link util.convert|convert} for more information.
  * @since 0.2.0
+ * @deprecated Unused since 0.3.0 and {@link fix #72|https://github.com/Zenika/immutadot/issues/72}, to be removed ?
  * @private
  */
 export const convertLodashFp = fn => convert(lodashFpConvert(fn))