Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a duck #237

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Added a duck #237

merged 4 commits into from
Nov 1, 2020

Conversation

RohanTheProgrammer
Copy link
Contributor

@RohanTheProgrammer RohanTheProgrammer commented Oct 30, 2020

Description

#11 issue
Here my contribution to "The Duck Gallery".

Please label this PR as hacktoberfest-accepted

Thank you 😊

@RohanTheProgrammer
Copy link
Contributor Author

RohanTheProgrammer commented Oct 30, 2020

I've done a PR and waiting for you to merge it soon
Can't wait 😊
@bpetetot

@bpetetot bpetetot merged commit ee74cb0 into zenika-open-source:master Nov 1, 2020
@RohanTheProgrammer
Copy link
Contributor Author

RohanTheProgrammer commented Nov 3, 2020

Sir, you labelled this after October. Do you think it will count in Hacktoberfest 2020

@bpetetot
Copy link
Collaborator

bpetetot commented Nov 3, 2020

Yes it will count because the whole repository is tagged hacktoberfest, so all the merged PRs on this repository will count for hacktoberfest

Here the conditions:
https://hacktoberfest.digitalocean.com/hacktoberfest-update

PRs count if:
Submitted during the month of October AND
Submitted in a public repo AND (
  The PR is labelled as hacktoberfest-accepted by a maintainer OR
  Submitted in a repo with the hacktoberfest topic AND (
    The PR is merged OR
    The PR has been approved
  )
)

@RohanTheProgrammer
Copy link
Contributor Author

RohanTheProgrammer commented Nov 3, 2020 via email

@RohanTheProgrammer
Copy link
Contributor Author

Sir on my Hacktoberfest profile it is showing pending can you help me out with this.

Any kind of help you can do will be highly appreciated 🙏😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants