Update notebook and fix pyyaml-include dependency issue
#16
Conversation
WalkthroughThe recent update brings notable changes aimed at enhancing YAML processing capabilities with the addition of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
strickvl
changed the title
pyyaml-include dependency issue
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (2)
- requirements.txt (1 hunks)
- template/quickstart.ipynb (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- template/quickstart.ipynb
Additional comments not posted (1)
requirements.txt (1)
6-6: Ensure compatibility ofpyyaml-include<2.0with other project dependencies and future upgrade plans.
There was a problem hiding this comment.
Actionable comments posted: 4
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/actions/starter_template_test/action.yml (1 hunks)
Additional comments not posted (6)
.github/actions/starter_template_test/action.yml (6)
39-43: Ensure the Git configuration commands are executed correctly in non-Windows environments.
46-50: Ensure the Git configuration commands are executed correctly in Windows environments.
72-73: Ensure the concatenation of requirements files is done correctly to manage dependencies efficiently.
33-36: Ensure the Python setup step is configured correctly with the specified Python version.
26-30: Ensure the checkout step is configured correctly with the specified repository and reference.
80-85: Ensure thepytestcommand is executed correctly to run the tests, with theZENML_STACK_NAMEenvironment variable set appropriately.
| - name: Install wheel | ||
| shell: bash | ||
| run: | | ||
| pip install wheel uv |
There was a problem hiding this comment.
Replace uv with python -m before pip commands to ensure correct syntax and standard practice.
- pip install wheel uv
+ python -m pip install wheelCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| pip install wheel uv | |
| python -m pip install wheel |
| if: ${{ inputs.ref-zenml != '' }} | ||
| shell: bash | ||
| run: | | ||
| uv pip install --system "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" |
There was a problem hiding this comment.
Correct the use of uv before pip commands and remove the redundant --system flag.
- uv pip install --system "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}"
+ python -m pip install "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| uv pip install --system "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" | |
| python -m pip install "git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" "zenml[server]@git+https://github.com/zenml-io/zenml.git@${{ inputs.ref-zenml }}" |
| if: ${{ inputs.ref-zenml == '' }} | ||
| shell: bash | ||
| run: | | ||
| uv pip install --system zenml "zenml[server]" |
There was a problem hiding this comment.
Correct the use of uv before pip commands and remove the redundant --system flag.
- uv pip install --system zenml "zenml[server]"
+ python -m pip install zenml "zenml[server]"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| uv pip install --system zenml "zenml[server]" | |
| python -m pip install zenml "zenml[server]" |
| - name: Install requirements | ||
| shell: bash | ||
| run: | | ||
| uv pip install --system -r ./local_checkout/all-requirements.txt |
There was a problem hiding this comment.
Correct the use of uv before pip commands and remove the redundant --system flag.
- uv pip install --system -r ./local_checkout/all-requirements.txt
+ python -m pip install -r ./local_checkout/all-requirements.txtCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| uv pip install --system -r ./local_checkout/all-requirements.txt | |
| python -m pip install -r ./local_checkout/all-requirements.txt |
Made the zenml cloud use stand out a bit more
Summary by CodeRabbit
pyyaml-include<2.0for improved YAML processing.