Spell Check added #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
requested changes
Apr 4, 2024
Comment on lines
+3
to
+10
| "*.json", | ||
| "*.js", | ||
| "*.ipynb", | ||
| "src/zenml/zen_stores/migrations/versions/", | ||
| "tests/unit/materializers/test_built_in_materializer.py", | ||
| "tests/integration/functional/cli/test_pipeline.py", | ||
| "src/zenml/zen_server/dashboard/", | ||
| "examples/llm_finetuning/lit_gpt/" |
There was a problem hiding this comment.
These need updating. They relate to the core ZenML package, not this repository.
Comment on lines
+6
to
+7
| # Run typos command with appropriate options | ||
| typos --config "$TYPOS_CONFIG" --write-changes |
There was a problem hiding this comment.
I think we don't want to actually write changes. We just want to surface any errors for them to be manually corrected.
|
@awanshahid1119 just checking, are you able to resolve the conflicts and make the relevant changes requested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spellcheck.sh:
Purpose: Automates spellchecking process using typos tool.
Usage: Execute bash scripts/spellcheck.sh to identify spelling errors in project files.
_typos.toml:
Purpose: Configurations for spellchecking process.
Usage: Customize options like file exclusions and word exceptions for accurate spellchecking.
spellcheck.yml:
Purpose: GitHub Actions workflow for CI spellchecking.
Usage: Automates spellchecking on pull requests, ensuring code quality with accurate spelling checks.