Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature/PRD-374-dag-missing-info): docker image collapsible #592

Merged
merged 12 commits into from
May 8, 2024

Conversation

atzin-escandia
Copy link
Contributor

@atzin-escandia atzin-escandia commented May 8, 2024

📝 ##feature/PRD-374-dag-missing-info

Description

(https://www.notion.so/zenml/What-s-missing-in-the-DAG-visualizer-f3127b697d584cdfac84a7e656fba6a5)

  • 📸 Screenshots:
Screenshot 2024-05-07 at 19 39 33 Screenshot 2024-05-07 at 19 39 42 Screenshot 2024-05-07 at 19 39 54 Screenshot 2024-05-07 at 19 40 04 Screenshot 2024-05-07 at 19 40 18

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for zenmlapp failed.

Name Link
🔨 Latest commit efd59c8
🔍 Latest deploy log https://app.netlify.com/sites/zenmlapp/deploys/663b38f00d33f70008406bf2

Copy link
Contributor

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldnt have anything in common with the services inside the cloud dashboard 🤔

src/assets/icons/docker.svg Outdated Show resolved Hide resolved
@Cahllagerfeld
Copy link
Contributor

Cahllagerfeld commented May 8, 2024

There are also some deepscan things to be fixed as well as the cla bot

@Cahllagerfeld Cahllagerfeld changed the base branch from main to future May 8, 2024 08:49
Copy link
Contributor

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some inconsistencies with the icons, and also the badges

Isn't cached and cache disabled kind of the opposite?

grafik grafik

Fixed icons:
image

Fixed Caches only visible when boolean

src/components/steps/step-sheet/DetailsTab.tsx Outdated Show resolved Hide resolved
src/components/MetadataCards.tsx Outdated Show resolved Hide resolved
src/data/pipeline-builds/all-pipeline-builds-query.ts Outdated Show resolved Hide resolved
src/types/pipeline-builds.ts Outdated Show resolved Hide resolved
src/data/pipeline-builds/all-pipeline-builds-query.ts Outdated Show resolved Hide resolved
src/data/pipeline-builds/all-pipeline-builds-query.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far,

things that I couldnt test locally so far, but I hope you did are

  • Docker Image collapsbile
  • code repository

@schustmi told me that he had some things prepared for you there though

RE:

As in the cloud-dashboard (https://github.com/zenml-io/zenml-cloud-ui/pull/404#issue-2283898706):

To display the docker image card you can try this:


Testing:

On local with PROD .env:
cloud.zenml.io/organizations/cb2d7fb6-3fa6-45bd-a730-6bf287d824c8/tenants/a26f7e86-96ab-4728-87c3-b0da59f01fb1/runs/ef9baa98-7d21-42da-bd5c-5f312a73cb60

@atzin-escandia atzin-escandia merged commit 595d942 into future May 8, 2024
2 of 3 checks passed
@atzin-escandia atzin-escandia deleted the feature/PRD-374-dag-missing-info branch May 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants