Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests #118

Merged
merged 52 commits into from
Oct 14, 2021
Merged

add tests #118

merged 52 commits into from
Oct 14, 2021

Conversation

alex-zenml
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to change)
  • [ x] I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@alex-zenml alex-zenml added the internal To filter out internal PRs and issues label Oct 7, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alex-zenml alex-zenml changed the title update add tests Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #118 (8605f3b) into main (d4e7e63) will increase coverage by 1.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   47.21%   49.14%   +1.92%     
==========================================
  Files          67       65       -2     
  Lines        1974     1921      -53     
==========================================
+ Hits          932      944      +12     
+ Misses       1042      977      -65
Impacted Files Coverage Δ
src/zenml/utils/path_utils.py 60.17% <ø> (+8.84%) ⬆️
src/zenml/constants.py 93.54% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e7e63...8605f3b. Read the comment docs.

htahir1
htahir1 requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing progress. Looking forward to reading more amazing tests! Left just minor adjustments.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/core/test_repo.py Outdated Show resolved Hide resolved
tests/metadata/test_base_metadata_wrapper.py Outdated Show resolved Hide resolved
tests/utils/test_analytics_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Show resolved Hide resolved
tests/utils/test_path_utils.py Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
@strickvl
Copy link
Contributor

strickvl commented Oct 7, 2021

Thanks for these, @htahir1. I'll read up on what hypothesis is as well as the pytest implementation of temporary directories and files. Will rework this as per your comments.

@alex-zenml
Copy link
Contributor Author

@hamzamaiot I'm done with all the refactoring / changes as you requested. AFAICS this is good to go, pending your approval / final review. The only thing that is hanging is the comment / question / problem above.

htahir1
htahir1 requested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, almost there! Left some final comments, but all minor!

tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
src/zenml/constants.py Outdated Show resolved Hide resolved
alex-zenml
alex-zenml commented Oct 14, 2021
View reviewed changes
Copy link
Contributor Author

@alex-zenml alex-zenml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment should be here.

tests/utils/test_analytics_utils.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Outdated Show resolved Hide resolved
tests/utils/test_analytics_utils.py Outdated Show resolved Hide resolved
alex-zenml
alex-zenml commented Oct 14, 2021
View reviewed changes
Copy link
Contributor Author

@alex-zenml alex-zenml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should clear the final pieces up.

htahir1
htahir1 requested changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last minor things. Also a general thought as we just went over it: Should these tests cover all artifact stores? Or how do we handle different file system tests? Open to suggestions

src/zenml/constants.py Outdated Show resolved Hide resolved
tests/utils/test_path_utils.py Show resolved Hide resolved
tests/utils/test_path_utils.py Show resolved Hide resolved
@htahir1 htahir1 merged commit e43ae22 into main Oct 14, 2021
@htahir1 htahir1 deleted the alex/tests branch October 14, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strickvl strickvl strickvl left review comments

@htahir1 htahir1 htahir1 requested changes

@bcdurak bcdurak Awaiting requested review from bcdurak

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-zenml @CLAassistant @strickvl @htahir1