Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying Kubernetes container resource requests and limits #1223

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Allow specifying Kubernetes container resource requests and limits #1223

merged 3 commits into from
Jan 13, 2023

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Jan 9, 2023

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Jan 9, 2023
@schustmi schustmi linked an issue Jan 9, 2023 that may be closed by this pull request
[BUG]: ZenML GPU scheduling #1204
Closed
@github-actions
Copy link
Contributor

@AlexejPenner
1.25 (one and twenty-five hundredths) business days have passed since the review started. Pretty please review the PR.

AlexejPenner
AlexejPenner approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@schustmi schustmi merged commit fa683f0 into develop Jan 13, 2023
@schustmi schustmi deleted the feature/kubernetes-resources branch January 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexejPenner AlexejPenner AlexejPenner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: ZenML GPU scheduling
2 participants
@schustmi @AlexejPenner