Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Michael/type annotations #137

Merged
merged 30 commits into from
Oct 20, 2021
Merged

Michael/type annotations #137

merged 30 commits into from
Oct 20, 2021

Conversation

schustmi
Copy link
Contributor

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

Briefly describe the changes you have introduced.
Added type annotations for everything.

@schustmi
Update mypy dependency version to enable reading config from pyprojec…
bf7b703 
…t.toml
@schustmi
Type hints for annotation classes
3832855
@schustmi
Type hints for artifact stores
30dc6b7
@schustmi
Type hints for artifacts
e1f3c38
@schustmi
Explicitly reexport remote filesystem prefixes
40a1f2f
@schustmi
Add type hints for exceptions
5fb6fb7
@schustmi
Merge branch 'main' into michael/type-annotations
f6fd385
@schustmi
Add type annotations for some files
015b0c2
@schustmi
Merge branch 'main' into michael/type-annotations
d40433d
@schustmi
Merge branch 'main' into michael/type-annotations
7aef0fa
@schustmi
Add some type annotations
ff83c22
@schustmi
Merge branch 'main' into michael/type-annotations
2da1bbb
@schustmi
Add type annotations for CLI
7b514e2
@schustmi
Add type hints for util files
2719b0e
@schustmi
Add more type annotations
70ce1fe
@schustmi
More type annotations
de41d28
@schustmi
Even more type annotations
b0c1519
@schustmi
Add type annotations for materializers + some other misc files
c944ee7
@schustmi
Merge branch 'main' into michael/type-annotations
9744b9d
@schustmi
Add type annotations for orchestrators
f83540c
@schustmi
Add almost all remaining type annotations
b7c775e
@schustmi
Merge branch 'main' into michael/type-annotations
7e28078
@schustmi
Fix tfx imports
f654a15
@schustmi
Fix tfx interface issues
65d4c16
@schustmi
Update mypy options
a549d47
@schustmi
Refactor tfx imports
008f420
@schustmi
Show mypy error codes
ac7f1c5
@schustmi
Fix final mypy errors
6fd4e0f
@schustmi
Merge branch 'main' into michael/type-annotations
964fc20
@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 20, 2021
@schustmi schustmi assigned alex-zenml and unassigned alex-zenml Oct 20, 2021
htahir1
htahir1 reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I am SO happy we did this now and not later. This is a fantastic PR. Thank you - I just left some small comments and thoughts. But generally this is amazing, and lets hope we have more type checking moving forward!

src/zenml/materializers/spec_materializer_registry.py Show resolved Hide resolved
src/zenml/orchestrators/airflow/airflow_component.py Show resolved Hide resolved
src/zenml/pipelines/pipeline_decorator.py Show resolved Hide resolved
src/zenml/types/pytorch_types.py Show resolved Hide resolved
src/zenml/utils/yaml_utils.py Show resolved Hide resolved
@htahir1
Copy link
Contributor

htahir1 commented Oct 20, 2021

Just amazing work!

@htahir1 htahir1 merged commit 2914fe3 into main Oct 20, 2021
@htahir1 htahir1 deleted the michael/type-annotations branch October 20, 2021 16:34
@schustmi
Copy link
Contributor Author

Thanks! This is still missing the CI-integration and pre-commit which I'll add tomorrow in a separate PR once we got all the annotations on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 left review comments

@bcdurak bcdurak Awaiting requested review from bcdurak

@alex-zenml alex-zenml Awaiting requested review from alex-zenml

Assignees
No one assigned
Labels
internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schustmi @htahir1 @alex-zenml