Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZenML Version Downgrade - Silence Warnning #1477

Merged
merged 5 commits into from
Apr 12, 2023
Merged

ZenML Version Downgrade - Silence Warnning #1477

merged 5 commits into from
Apr 12, 2023

Conversation

safoinme
Copy link
Contributor

@safoinme safoinme commented Apr 7, 2023

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Apr 7, 2023
@safoinme safoinme requested a review from strickvl April 11, 2023 07:12
fa9r
fa9r approved these changes Apr 11, 2023
View reviewed changes
src/zenml/config/global_config.py Outdated Show resolved Hide resolved
strickvl
strickvl requested changes Apr 11, 2023
View reviewed changes
src/zenml/cli/downgrade.py Outdated Show resolved Hide resolved
src/zenml/cli/downgrade.py Outdated Show resolved Hide resolved
src/zenml/cli/downgrade.py Outdated Show resolved Hide resolved
src/zenml/cli/downgrade.py Outdated Show resolved Hide resolved
safoinme and others added 2 commits April 11, 2023 08:07
@safoinme @strickvl @fa9r
Apply suggestions from code review
5caf95c 
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Felix Altenberger <felix@zenml.io>
@safoinme
Merge branch 'develop' into bugfix/FRW-1805-zenm-version-downgrade
5291a50
@safoinme safoinme requested a review from strickvl April 11, 2023 10:05
@safoinme safoinme merged commit 402eda0 into develop Apr 12, 2023
@safoinme safoinme deleted the bugfix/FRW-1805-zenm-version-downgrade branch April 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strickvl strickvl strickvl approved these changes

@fa9r fa9r fa9r approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@safoinme @strickvl @fa9r