Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the namespace and service account k8s orchestrator settings #1722

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Document the namespace and service account k8s orchestrator settings #1722

merged 1 commit into from
Aug 7, 2023

Conversation

stefannica
Copy link
Contributor

Describe changes

Documented the namespace and service account k8s orchestrator settings.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@stefannica stefannica requested review from fa9r and bcdurak July 28, 2023 13:43
@github-actions github-actions bot added internal To filter out internal PRs and issues documentation Improvements or additions to documentation labels Jul 28, 2023
fa9r
fa9r approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding that, also very clear how you formulated it 👍

@stefannica stefannica merged commit 03a5639 into develop Aug 7, 2023
5 checks passed
@stefannica stefannica deleted the docs/frw-2124-kube-orchestrator branch August 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@fa9r fa9r fa9r approved these changes

@bcdurak bcdurak Awaiting requested review from bcdurak

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefannica @htahir1 @fa9r