Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable methods for local case #2457

Conversation

AlexejPenner
Copy link
Contributor

Describe changes

Some methods should not be allowed for the fully local setup where the client is directly connected to the SqlZenStore. This is because there is some custom logic, that is only run in the layer between endpoint and database:

Client -> RestZenStore -> Server-Endpoint -> Custom handler -> SqlZenStore

This custom layer would be bypassed in the local setup:

Client -> SqlZenStore

For this reason the relevant methods are disallowed.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Copy link
Contributor

coderabbitai bot commented Feb 21, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Feb 21, 2024
@AlexejPenner AlexejPenner changed the title Feature/cloudk 393 raise for sql Disable methods for local case Feb 21, 2024
src/zenml/client.py Outdated Show resolved Hide resolved
src/zenml/client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested changes E2E seems to run smoothly on my end.
Consider adding test cases for this wrapper.

AlexejPenner and others added 2 commits February 21, 2024 15:33
Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
@AlexejPenner
Copy link
Contributor Author

With the suggested changes E2E seems to run smoothly on my end. Consider adding test cases for this wrapper.

Tests will be written on the mega branch that we are merging to. applied your review

Copy link
Contributor

@stefannica stefannica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexej, can you please look at the linter errors ? I think you have to add some type annotations to the decorator.

@AlexejPenner AlexejPenner force-pushed the feature/CLOUDK-393-raise-for-sql branch from b5f33fa to cf8a1c3 Compare February 21, 2024 17:07
@AlexejPenner
Copy link
Contributor Author

Alexej, can you please look at the linter errors ? I think you have to add some type annotations to the decorator.

done

@AlexejPenner AlexejPenner merged commit 93c39ef into feature/CLOUD-504-trigger-blueprint Feb 22, 2024
17 of 35 checks passed
@AlexejPenner AlexejPenner deleted the feature/CLOUDK-393-raise-for-sql branch February 22, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants