-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable methods for local case #2457
Disable methods for local case #2457
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…K-393-raise-for-sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggested changes E2E seems to run smoothly on my end.
Consider adding test cases for this wrapper.
Co-authored-by: Andrei Vishniakov <31008759+avishniakov@users.noreply.github.com>
Tests will be written on the mega branch that we are merging to. applied your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alexej, can you please look at the linter errors ? I think you have to add some type annotations to the decorator.
b5f33fa
to
cf8a1c3
Compare
done |
93c39ef
into
feature/CLOUD-504-trigger-blueprint
Describe changes
Some methods should not be allowed for the fully local setup where the client is directly connected to the SqlZenStore. This is because there is some custom logic, that is only run in the layer between endpoint and database:
Client -> RestZenStore -> Server-Endpoint -> Custom handler -> SqlZenStore
This custom layer would be bypassed in the local setup:
Client -> SqlZenStore
For this reason the relevant methods are disallowed.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes