Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some important docs updates #2463

Merged
merged 49 commits into from
Feb 23, 2024
Merged

Some important docs updates #2463

merged 49 commits into from
Feb 23, 2024

Conversation

htahir1
Copy link
Contributor

@htahir1 htahir1 commented Feb 22, 2024

Describe changes

I fixed a few things and made zenml cloud more visible, as we offer a free account now.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Copy link
Contributor

coderabbitai bot commented Feb 22, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Feb 22, 2024
@htahir1 htahir1 requested a review from bcdurak February 22, 2024 16:24
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 7%, saving 68.43 KB.

Filename Before After Improvement Visual comparison
docs/book/.gitbook/assets/zenml-cloud-tenant-overview.png 270.12 KB 242.83 KB -10.1% View diff
docs/book/.gitbook/assets/zenml-hero.png 139.14 KB 121.37 KB -12.8% View diff
docs/book/.gitbook/assets/zenml-why.png 563.77 KB 540.40 KB -4.1% View diff

231 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md Outdated Show resolved Hide resolved
docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md Outdated Show resolved Hide resolved
docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md Outdated Show resolved Hide resolved
docs/book/getting-started/installation.md Outdated Show resolved Hide resolved
htahir1 and others added 6 commits February 22, 2024 17:53
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
…e.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
htahir1 and others added 3 commits February 23, 2024 10:00
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
@strickvl strickvl changed the title Some imp docs updates Some important docs updates Feb 23, 2024
@strickvl strickvl self-requested a review February 23, 2024 10:20
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now. just a few remaining nits / questions.

README.md Outdated
</div>

ZenML aims to optimize your entire machine learning lifecycle - you'll be 80% faster to production, generate 3x more models, and massively reduce your cloud spend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of "aims to", something more active?

  • ZenML optimizes your entire...
  • ZenML is all about optimizing your...
  • etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also feels like maybe these very precise numbers need links to user case studies etc. without links it feels a bit arbitrary? (Not sure how others would read it, though).

README.md Outdated Show resolved Hide resolved
htahir1 and others added 3 commits February 23, 2024 11:26
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistake. thanks for cathcing!

docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md Outdated Show resolved Hide resolved
docs/book/getting-started/installation.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
</div>

ZenML optimizes your entire machine learning lifecycle - you'll be 80% faster to production, generate 3x more models, and massively reduce your cloud spend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these numbers can be very situational and it feels a bit off displaying them without any resources to back it up.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
htahir1 and others added 5 commits February 23, 2024 13:11
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
@htahir1 htahir1 merged commit 909ea63 into develop Feb 23, 2024
7 checks passed
@htahir1 htahir1 deleted the doc/some-imp-updates branch February 23, 2024 12:13
htahir1 added a commit that referenced this pull request Feb 23, 2024
* Add mention of deploying zenml in installation

* Add mention of deploying zenml in installation

* Add mention of deploying zenml in installation

* ZenML Cloud

* More ZenML Cloud

* Added assets

* README

* READ

* latest

* latest

* README

* README

* README

* README

* README

* README

* README

* Optimised images with calibre/image-actions

* README

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/cloud-system-architecture.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/getting-started/installation.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* latest

* README again

* More WHy

* Latest

* Latest

* Latest

* ZenmL Cloud

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* README again

* Apply suggestions from code review

Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>

* latest

* Update docs/book/getting-started/installation.md

Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>

* latest

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
(cherry picked from commit 909ea63)
@htahir1
Copy link
Contributor Author

htahir1 commented Feb 23, 2024

@strickvl @bcdurak thanks for the reviews. i merged and backported

adtygan pushed a commit to adtygan/zenml that referenced this pull request Mar 21, 2024
* Add mention of deploying zenml in installation

* Add mention of deploying zenml in installation

* Add mention of deploying zenml in installation

* ZenML Cloud

* More ZenML Cloud

* Added assets

* README

* READ

* latest

* latest

* README

* README

* README

* README

* README

* README

* README

* Optimised images with calibre/image-actions

* README

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/cloud-system-architecture.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/getting-started/installation.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update docs/book/deploying-zenml/zenml-cloud/zenml-cloud.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* latest

* README again

* More WHy

* Latest

* Latest

* Latest

* ZenmL Cloud

* Update README.md

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* README again

* Apply suggestions from code review

Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>

* latest

* Update docs/book/getting-started/installation.md

Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>

* latest

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants