-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KServe integration #2495
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Please be sure to update https://www.notion.so/zenml/5d31ff9557554f32b14306f0f9417d7e?v=b7fc78b938ed4006a92a6697b8c41491 as well with details of the removal. The zenml.io integrations guide needs updating + please also check mlstacks though I think we removed it from mlstacks a while back. |
Another question, if someone has kserve in their DB (i.e. previous pipeline runs from a long time ago etc), do any of these changes break zenml for them? |
@strickvl It will break only if they try to use it, but it doesn't exist, we had a similar issue with Skypilot in m&h tenant 2 weeks ago where they just failed to use any stack that had it since the path of it was already registered in db but it didn't break there zenml |
Describe changes
After a few months of being deprecated from docs, it's time to remove KServe from the ZenML repo.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes